Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu toggle: pf-m-action modifier no longer needed #11095

Closed
tlabaj opened this issue Oct 1, 2024 · 0 comments · Fixed by #11096
Closed

Menu toggle: pf-m-action modifier no longer needed #11095

tlabaj opened this issue Oct 1, 2024 · 0 comments · Fixed by #11096
Assignees
@tlabaj
Labels
PF Team
Milestone
Penta final release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Oct 1, 2024 •
edited
Loading

Please describe the issue
follow up to PR patternfly/patternfly#7100

remove the pf-m-action modifier from the split button menu toggle. We no longer need the 'actionvariant. consider removing theSplitButtonOptions.variant` prop all together.
@tlabaj tlabaj self-assigned this Oct 1, 2024
@tlabaj tlabaj added this to the Penta final release milestone Oct 1, 2024
@tlabaj tlabaj added the P1 ⭐ label Oct 1, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 1, 2024
@tlabaj tlabaj moved this from Needs triage to In Progress in PatternFly Issues Oct 1, 2024
This was referenced Oct 1, 2024
Closed
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlabaj tlabaj

Labels
PF Team
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
Development

Successfully merging a pull request may close this issue.

fix(Menu toggle): Remove pf-m-action modifier tlabaj/patternfly-react
1 participant
@tlabaj