-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Menu toggle): Remove pf-m-action modifier #11096
Conversation
Preview: https://patternfly-react-pr-11096.surge.sh A11y report: https://patternfly-react-pr-11096-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L🎃TM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor example update to get it working, otherwise lgtm. Slider also looks like it's acting fine on the preview.
packages/react-core/src/components/MenuToggle/examples/MenuToggleSplitButtonAction.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What: Closes #11095
This PR does the following:
SplitButtonOptions
interface and prop since it is no longer needed because there is no longer a variant. Consumers will now pass items directly tosplitButtonItems
prop