Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume core updates: Toolbar and Action List #9677

Closed
Tracked by #152 ...
andrew-ronaldson opened this issue Sep 26, 2023 · 2 comments · Fixed by #10041
Closed
Tracked by #152 ...

Consume core updates: Toolbar and Action List #9677

andrew-ronaldson opened this issue Sep 26, 2023 · 2 comments · Fixed by #10041
Assignees

Comments

@andrew-ronaldson
Copy link
Collaborator

andrew-ronaldson commented Sep 26, 2023

Follow up to Core Toolbar issue

in core bump PR #10022 he following was done:

  • removed application of pf-m-chip-container modifier on toolbar group in ToolbarExpandableContent.tsx
  • removed application of pf-m-buttonGroup modifier on toolbar group in
  • removed import of @patternfly/react-tokens/dist/esm/c_toolbar__item_Width since it no longer exists. also comment out widths prop application since it depends on the token.
  • Removed bulkSelect, overflowMenu, searchFilter modifier applications on toolbar item
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 26, 2023
@andrew-ronaldson andrew-ronaldson moved this from Needs triage to Not started in PatternFly Issues Sep 26, 2023
@andrew-ronaldson andrew-ronaldson added this to the 2023.Q4 milestone Sep 26, 2023
@andrew-ronaldson andrew-ronaldson changed the title Consume core updates: Toolbar and Action List ( Follow up to issue) Consume core updates: Toolbar and Action List Sep 26, 2023
Copy link

stale bot commented Nov 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 25, 2023
@andrew-ronaldson andrew-ronaldson modified the milestones: 2023.Q4, 2024.Q1 Nov 27, 2023
@stale stale bot closed this as completed Dec 12, 2023
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Dec 12, 2023
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Dec 16, 2023
@stale stale bot closed this as completed Dec 31, 2023
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Dec 31, 2023
@evwilkin evwilkin removed the wontfix label Jan 4, 2024
@evwilkin evwilkin reopened this Jan 4, 2024
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Jan 4, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Jan 16, 2024
@tlabaj tlabaj moved this from Backlog to On deck in PatternFly Issues Jan 22, 2024
@thatblindgeye thatblindgeye self-assigned this Jan 23, 2024
@thatblindgeye thatblindgeye moved this from On deck to In Progress in PatternFly Issues Jan 24, 2024
@thatblindgeye
Copy link
Contributor

Closed by #10041 and #10042

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants