feat(ActionList): consumed Penta updates #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
requested review from
mattnolting,
a team,
wise-king-sullyman,
kmcfaul,
andrew-ronaldson and
lboehling
and removed request for
a team
|
Preview: https://patternfly-react-pr-10041.surge.sh A11y report: https://patternfly-react-pr-10041-a11y.surge.sh |
wise-king-sullyman
approved these changes
Jan 30, 2024
andrew-ronaldson
approved these changes
Feb 3, 2024
kmcfaul
approved these changes
Feb 13, 2024
mattnolting
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
LPTM 🚀
What: Towards #9677
Couple questions:
- For the "Action list with cancel button" example, should the "Cancel" button be in the same group as "Next" and "Back" buttons (how it is in Core), or should it be separate visually and structurally (how it is in this PR)? EDIT: update core example to use separate groups
@thatblindgeye deferring to design @lboehling @andrew-ronaldson
- For the "Action list with icons" example, is it intended that that is the only time ActionListItem component should not be wrapped in an ActionListGroup? Or should we be consistent about always needing the ActionListGroup wrapping ActionListItem components? EDIT:
Open core issue to update pf-m-icons styling on pf-v5-c-action-list to also update group column-gap var (column-gap on action list should remain the same)PR opened by Matt - feat(action-list): added icon group variable update patternfly#6263
@thatblindgeye we decided grouping is optional, but application of .pf-m-icons updates spacing for all element.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Towards #9677
Couple questions:
Open core issue to update pf-m-icons styling on pf-v5-c-action-list to also update group column-gap var (column-gap on action list should remain the same)PR opened by Matt - feat(action-list): added icon group variable update patternfly#6263Additional issues: