-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): Replace Text, TextContent, TextList and TextListItem with Content - PART 1 #10611
Conversation
Preview: https://patternfly-react-pr-10611.surge.sh A11y report: https://patternfly-react-pr-10611-a11y.surge.sh |
7922559
to
d49a920
Compare
d49a920
to
6aee8c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update Content.tsx
to export as Content
, it's still being exported as Text
and is referred to as Text
in the docs and examples (including the imports and usage in examples). The examples should use Content
instead of the Text
suite (maybe keeping a couple Text-using examples if we are keeping the Text components around, but my impression was they were being removed?).
Do we want to remove TextContent, TextList, TextListItem or are we keeping them for now? Not a blocker if we want to keep them.
@kmcfaul The reason for doing the changes separately in two PRs is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10395, #10390
This is a PART 1, it is not a breaking change yet, see this comment.
Part 2 PR: #10643
Codemod PR: patternfly/pf-codemods#675
Org issue to replace Text: patternfly/patternfly-org#4087
(link to previous closed PR: #10579)