-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Wizard): implement success status on steps / nav items #10714
feat(Wizard): implement success status on steps / nav items #10714
Conversation
Preview: https://patternfly-react-pr-10714.surge.sh A11y report: https://patternfly-react-pr-10714-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we lost the step number in the toggle for all steps that don't have a status
https://patternfly-react-pr-10714.surge.sh/components/wizard/react/basic/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the above lgtm, looks like it's just to do with isActiveStepStatus not having any default value within WizardToggle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧙♂️
Your changes have been released in:
Thanks for your contribution! 🎉 |
Closes #10691
updated Step status example in wizard docs: https://patternfly-react-pr-10714.surge.sh/components/wizard#step-status