feat(DataListAction): Remove isPlainButtonAction prop (#775)

* feat(DataListAction): Remove isPlainButtonAction prop * fixes from core review comments * remove .history and add it to gitignore
patternfly · Sep 25, 2024 · 35bb6b4 · 35bb6b4
1 parent 597b3f9
commit 35bb6b4
Show file tree

Hide file tree

Showing 6 changed files with 71 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -4,4 +4,7 @@ lerna-output.txt
 .idea
 test/packages/*
 .DS_Store
-dist
+dist
+
+# IDE - VSCode
+.history
diff --git a/...RemoveIsPlainButtonActionProp/dataListAction-remove-isPlainButtonAction-prop.md b/...RemoveIsPlainButtonActionProp/dataListAction-remove-isPlainButtonAction-prop.md
@@ -0,0 +1,17 @@
+### dataListAction-remove-isPlainButtonAction-prop [(#10939)](https://github.com/patternfly/patternfly-react/pull/10939)
+
+The `isPlainButtonAction` prop has been removed from DataListAction as a wrapper is no longer needed.
+
+#### Examples
+
+In:
+
+```jsx
+%inputExample%
+```
+
+Out:
+
+```jsx
+%outputExample%
+```
diff --git a/...ctionRemoveIsPlainButtonActionProp/dataListAction-remove-isPlainButtonAction-prop.test.ts b/...ctionRemoveIsPlainButtonActionProp/dataListAction-remove-isPlainButtonAction-prop.test.ts
@@ -0,0 +1,25 @@
+const ruleTester = require("../../ruletester");
+import * as rule from "./dataListAction-remove-isPlainButtonAction-prop";
+
+ruleTester.run("dataListAction-remove-isPlainButtonAction-prop", rule, {
+  valid: [
+    {
+      code: `<DataListAction isPlainButtonAction />`,
+    },
+    {
+      code: `import { DataListAction } from '@patternfly/react-core'; <DataListAction someOtherProp />`,
+    },
+  ],
+  invalid: [
+    {
+      code: `import { DataListAction } from '@patternfly/react-core'; <DataListAction isPlainButtonAction />`,
+      output: `import { DataListAction } from '@patternfly/react-core'; <DataListAction  />`,
+      errors: [
+        {
+          message: `The \`isPlainButtonAction\` prop has been removed from DataListAction as a wrapper is no longer needed.`,
+          type: "JSXOpeningElement",
+        },
+      ],
+    },
+  ],
+});
diff --git a/...ListActionRemoveIsPlainButtonActionProp/dataListAction-remove-isPlainButtonAction-prop.ts b/...ListActionRemoveIsPlainButtonActionProp/dataListAction-remove-isPlainButtonAction-prop.ts
@@ -0,0 +1,15 @@
+import { renameProps } from "../../helpers";
+
+// https://github.com/patternfly/patternfly-react/pull/10939
+module.exports = {
+  meta: { fixable: "code" },
+  create: renameProps({
+    DataListAction: {
+      isPlainButtonAction: {
+        newName: "",
+        message:
+          "The `isPlainButtonAction` prop has been removed from DataListAction as a wrapper is no longer needed.",
+      },
+    },
+  }),
+};
diff --git a/...tActionRemoveIsPlainButtonActionProp/dataListActionRemoveIsPlainButtonActionPropInput.tsx b/...tActionRemoveIsPlainButtonActionProp/dataListActionRemoveIsPlainButtonActionPropInput.tsx
@@ -0,0 +1,5 @@
+import { DataListAction } from "@patternfly/react-core";
+
+export const DataListActionRemoveIsPlainButtonActionPropInput = () => (
+  <DataListAction isPlainButtonAction/>
+);
diff --git a/...ActionRemoveIsPlainButtonActionProp/dataListActionRemoveIsPlainButtonActionPropOutput.tsx b/...ActionRemoveIsPlainButtonActionProp/dataListActionRemoveIsPlainButtonActionPropOutput.tsx
@@ -0,0 +1,5 @@
+import { DataListAction } from "@patternfly/react-core";
+
+export const DataListActionRemoveIsPlainButtonActionPropInput = () => (
+  <DataListAction />
+);