Handle v2 error #474
Open
Handle v2 error #474
+107
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recoverable errors are be shared with the Sender so that they might recover rather than necessarily waiting for the session to expire.
Only `Receiver.id()` needs to be public. Subdir can be a private pure function.
Pull Request Test Coverage Report for Build 12740129056Details
💛 - Coveralls |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #468 with a simple approach: Just add the methods to UncheckedProposal which can be cloned at the beginning of the receive process.
This seems to be is the least invasive way to make this change that I didn't even think of in my enumerated approaches in #468.
Alternatively, we could have some way to extract an ErrorContext from which an Error (request,context) could be extracted from an
ErrorContext::extract_req(e: Error) -> (Request, ohttp_ctx)But I think this gets us the progress we want and we can follow up if we decide that's a good idea with the rest of the receiver module error split.