Feature pydantic argparse cli #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make arguments inherit from `pydantic.fields.FieldInfo` and augment them with a `name` attribute - make a `Command` class that generates a `pydantic` model with the arguments the command takes - make commands take lists of specific arguments they take instead of having arguments know by which commands they are supported
Co-authored-by: Zhihan Zhang <[email protected]>
Co-authored-by: Nathan Sheffield <[email protected]>
Co-authored-by: Zhihan Zhang <[email protected]>
Co-authored-by: Zhihan Zhang <[email protected]>
Co-authored-by: Zhihan Zhang <[email protected]>
This method returns the same data, but with the `default` tuple (<type>, <value>) replaced by only <value>. This allows `Argument`s to be used when directly defining `pydantic` models instead of using `create_model()`.
…comprehensive test
# Conflicts: # looper/looper.py # requirements/requirements-all.txt
…c-argparse-cli # Conflicts: # looper/looper.py # requirements/requirements-all.txt
Co-authored-by: Nathan Sheffield <[email protected]>
Adding pydantic argparse cli and Refactor Looper Tests
|
This is failing pytest because we migrated to using a local instance of hello_looper that is pulled from github manually. Pytesting via Github actions cannot find the repository (because I gitignored the folder). Merging to dev for now. I will fix it there. |
|
And I confirmed all tests pass locally in both this branch and dev branch before and after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just continuing to merge down this work to the dev branch, see #472