Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability for adding and editing subsample tables #131

Closed
2 tasks done
khoroshevskyi opened this issue Mar 31, 2023 · 3 comments
Closed
2 tasks done

Add capability for adding and editing subsample tables #131

khoroshevskyi opened this issue Mar 31, 2023 · 3 comments
Assignees
Milestone

Comments

@khoroshevskyi
Copy link
Member

khoroshevskyi commented Mar 31, 2023

  • Add backed endpoint for editing subsample tables
  • Add UI for editing subsample tables

p.s.
in raw peppy subsample_dict is a list (I probably named it incorrectly🫥) So we can have more then one subsample table.

@nleroy917
Copy link
Member

I am close on this, but @khoroshevskyi, I'm getting a weird error from peppy when sending the subsample table data:

subsample_df = pd.DataFrame.from_dict(updated_project.subsample_table)
subsample_df_json = subsample_df.to_dict()

new_raw_project[SUBSAMPLE_RAW_DICT_KEY] = subsample_df_json
 new_raw_project[CONFIG_KEY] = current_project.config.to_dict()

new_project = Project().from_dict(new_raw_project)

>>> ValueError('DataFrame constructor not properly called!')

@khoroshevskyi
Copy link
Member Author

Now, UI has only one subsample table. What if project will have multiple subsample tables? I think it's not high priority, but it would be nice to think about this issue

@khoroshevskyi
Copy link
Member Author

Issue was partially solved. Subsample creation and modification on the UI was added (for one subsample table). Closing this, and opening separate issue: #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants