Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability updates + layout #139

Merged
merged 25 commits into from
Apr 28, 2023
Merged

Stability updates + layout #139

merged 25 commits into from
Apr 28, 2023

Conversation

nleroy917
Copy link
Member

@nleroy917 nleroy917 commented Apr 20, 2023

This includes a lot of stability improvements after the transition to React. Thanks for pointing out these things @khoroshevskyi

Improvements include:

  1. Change key-binding on global search
  2. Drag-n-drop was broken, it should now be fixed
  3. Files were not getting uploaded properly for project submission
  4. Sample table editing was broken due to trailing commas
  5. New project page layout
  6. Some new components + CSS utility classes to make front-end development easier
  7. Sort project list by default to most recent first in the list

@khoroshevskyi khoroshevskyi self-requested a review April 20, 2023 19:26
Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is few things that still have to be polished:

  1. Download zip 3 different places. I think this link (or downloading button) should be in one place. E.g under "Get project" drop button.

  2. We don't have https downloading link (only zip) so I wouldn't add it to our UI now.
    image

  3. PEP version shows incorrect version:
    image

  4. Add subtables to UI. In my opinion everything is ready for adding subsamples. + I just added functionality for updating subsample tables. So it shouldn't be big problem.

Everything else looks good:)

pephub/routers/api/v1/namespace.py Show resolved Hide resolved
@nleroy917
Copy link
Member Author

@khoroshevskyi Changes should be nearly complete now if you wanted to test it out.

@nleroy917 nleroy917 merged commit 2b1a47b into master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants