Fix getLastErrorModes deserialization #1806
Open
+11
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The operator cannot reconcile the cluster if you set a custom
getLastErrorModes
value in the RS config.Cause:
The Settings struct currently assumes
GetLastErrorModes
to have the same type as a replica set tag (ReplsetTags
), but this is not the type MongoDB expects. It instead expects the name of a replica set tag and an associated number which refers to the number of different tag values required to satisfy the write concern. See: https://www.mongodb.com/docs/manual/reference/replica-configuration/#mongodb-rsconf-rsconf.settings.getLastErrorModesSolution:
Have
GetLastErrorModes
use a new type that matches MongoDB behaviour. (type WriteConcernReplsetTags map[string]int
)Resolves #1759, I have tested this very quickly locally with a cluster that sets a getLastErrorModes value and it seems to work fine.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability