-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPS 388 small refactor on InitContainer, reuse it when needed - e2e test introduction for the case #811
base: main
Are you sure you want to change the base?
Conversation
574d9df
to
f3f51f2
Compare
@@ -22,7 +22,6 @@ const ( | |||
configVolumeName = "config" | |||
configMountPath = "/etc/binlog_server/config" | |||
storageCredsVolumeName = "storage" | |||
storageCredsMountPath = "/etc/binlog_server/storage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this since it wasn't used anywhere in the codebase.
b09cd00
to
62d68db
Compare
requests.memory: "16Gi" | ||
limits.cpu: "20" | ||
limits.memory: "32Gi" | ||
requests.cpu: "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requests.memory: "4Gi" | ||
limits.cpu: "4" | ||
limits.memory: "6Gi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increased memory in order to address some errors as reported here: https://percona-jenkins-artifactory-public.s3.amazonaws.com/cloud-ps-operator/PR-811/21e66a83/init-deploy.log
e.g.
logger.go:42: 18:50:03 | init-deploy | 2025-01-24 18:43:39 +0000 UTC Warning StatefulSet.apps init-deploy-orc FailedCreate create Pod init-deploy-orc-1 in StatefulSet init-deploy-orc failed error: pods "init-deploy-orc-1" is forbidden: exceeded quota: init-deploy-resource-quota, requested: limits.memory=1Gi, used: limits.memory=2560Mi, limited: limits.memory=3Gi statefulset-controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit: 7c64521
…e Quotas are specified
commit: 8a96dcd |
In this PR we followup on #806 and we add some small refactors to increase maintainability.
Resource Quotas yaml used for testing:
Tested the following 2 scenarios:
spec.mysql.clusterType: group-replication
spec.mysql.clusterType: async
Resources testing:
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability