Add in_response_to to Role::ProtocolMessage #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkip
force-pushed
the
GH-move-logic
branch
2 times, most recently
from
2abf5bc to
1ed5866
Compare
timlegge
reviewed
Apr 18, 2024
timlegge
reviewed
Apr 18, 2024
timlegge
reviewed
Apr 19, 2024
timlegge
reviewed
Apr 19, 2024
|
|
This attribute is needed in more than one type, so let's implement it. Consumers may need to add the required bit. In addition also add the success() method (although I think we need to call it is_success). Signed-off-by: Wesley Schwengle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute is needed in more than one type, so let's implement it.
Consumers may need to add the required bit.
In addition also add the success() method (although I think we need to
call it is_success).
Signed-off-by: Wesley Schwengle [email protected]