Correctly test NameID attributes #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6c63ed1 we introduced some logic to make NameID attributes optional. On the checks is that urn:oasis:names:tc:SAML:2.0:nameidformat:persistent is special. There are two problems with this, one: urn:oasis:names:tc:SAML:2.0:nameidformat:persistent should be urn:oasis:names:tc:SAML:2.0:nameid-format:persistent. And two: the test in t/07-logout-request.t should test that SPNameQualifier and NameQualifier are actually set and they are now not set (for the test that is). By fixing the typo, we need to change the tests to test the correct thing. Closes: perl-net-saml2#213 Signed-off-by: Wesley Schwengle <[email protected]>
waterkip
force-pushed
the
GH-213-update_typo
branch
from
544d7ea to
67438b5
Compare
Signed-off-by: Wesley Schwengle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6c63ed1 we introduced some logic to make NameID attributes optional. On the checks is that urn:oasis:names:tc:SAML:2.0:nameidformat:persistent is special. There are two problems with this, one:
urn:oasis:names:tc:SAML:2.0:nameidformat:persistent should be urn:oasis:names:tc:SAML:2.0:nameid-format:persistent. And two: the test in t/07-logout-request.t should test that SPNameQualifier and NameQualifier are actually set and they are now not set (for the test that is). By fixing the typo, we need to change the tests to test the correct thing.
Closes: #213