Fixed case where an error occurs if a handle unsubscribes in the middle of a publish #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see where it errors here:
http://jsfiddle.net/EG4CL/
This is happening due to the way jQuery's
each
method is implemented. In this case, jQuery caches the length property in thefor
loop it uses to iterate over the items. When splice is used, that array (of course) is shortened but jQuery is still going to try to keep iterating using the original length.When that happens (in jQuery),
this
becomeswindow
and not the callback the user wants: