Allow callers of publish() to see how many subscribers were notified. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermine how many (if any) subscribers received the topic. This would aid debugging because publishers could log when there are no subscribers for the topic at the time the topic is published.
…cribers are mandatory. Added options to allow callers to specify a default for whether topics must have subscribers or not (so that not every publish call needs altering in an application). The options also allow a callback "onNoSubscribers" that overrides the default behaviour which is to log an error if the host has a console, or simply alert if not (I'm looking at you IE6).
…stHaveSubscribers is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a return value to the publish method allows callers to determine how many (if any) subscribers received the topic. This would aid debugging because publishers could take action in the event there are no subscribers to the topic at the time the topic is published.