-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/imx-enet: Add support for ethernet in imxrt1170-evkb #99
Open
julianuziemblo
wants to merge
21
commits into
master
Choose a base branch
from
julianuziemblo/enet-imxrt1170-evkb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: RTOS-507
change code style to match coding conventions JIRA: RTOS-507
refactor printfs with repeated format pattern into ephy_printf JIRA: RTOS-507
JIRA: RTOS-507
JIRA: RTOS-507
first step to add separate implementation files for imx6ull and imxrt106x gpio JIRA: RTOS-507
JIRA: RTOS-507
remove active value inversion in gpio_wait because the value is already being inverted in gpio_get JIRA: RTOS-507
JIRA: RTOS-507
fix 7b90e8e: - add _Atomic specifier to volatile vars used as atomics - change operations on the vars to atomic_* JIRA: RTOS-507
fix packet buffer handling for targets with page size less than packet buffer size JIRA: RTOS-507
add PHY model specification to the ENET config string. different config is needed when the target supports different PHY model per ENET device. JIRA: RTOS-963
Update README with appropriate information about new changes to drivers/ephy and drivers/imx-enet. JIRA: RTOS-963
JIRA: RTOS-963
JIRA: RTOS-963
Unit Test Results7 958 tests +233 7 414 ✅ +404 40m 31s ⏱️ + 3m 22s For more details on these failures, see this check. Results for commit 20981d2. ± Comparison against base commit b0964a1. This pull request removes 729 and adds 962 tests. Note that renamed tests count towards both.
This pull request removes 137 skipped tests and adds 36 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
JIRA: RTOS-963
ENET1 and ENET_1G on imxrt1170-evkb need their own, separate MDIO busses to work JIRA: RTOS-963
Add information about iMX.RT1170's EVKB board's needed Ethernet config JIRA: RTOS-963
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1170-evkb
branch
from
December 10, 2024 10:33
b3c7e8b
to
20981d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Ethernet support for iMX RT106x, merging the code with existing driver for iMX RT6UL/6ULL in drivers/imx-enet.c
Motivation and Context
JIRA: RTOS-963
This PR is not this big by itself - it contains changes from (#96).
Checks for target
armv7a7-imx6ull-evk
will not be passing because of the changes to handling the plo init script.Types of changes
Enet init script now is required to include the PHY model used, which is needed when the same board contains multiple enet devices with different PHYs. More info: phoenix-rtos/phoenix-rtos-project#1247
How Has This Been Tested?
armv7a7-imx6ull-evk
,armv7m7-imxrt106xx-evk
,armv7m7-imxrt117x-evkb
(newly added in projects/(imx6ull, imxrt106x, imxrt117x): Add ENET config phoenix-rtos-project#1247), ``.Checklist:
Special treatment