Fixes broken installation script/Trovebox UI Setup issue which preven… #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted installation/setup The current sciprt does not touch the DB. The UI setup fails, As it attempts to access a user table while at the same time instructing you to create a blank DB. #1572 The SQL is taken from https://github.com/photo/frontend/blob/master/src/configs/upgrade/db/mysql/mysql-base.php#L294-L303. The script will give you 3 changes to get your password right before providing instructions and SQL to the user on how to manually resolve the db schema issue once they have the password.
|
To confirm, I tested all conditions |
|
Thanks for the PR. Would like to know why this is happening in the first place. One issue I noticed is that the user might select a prefix for the db tables and the setup script doesn't account for that. I left a comment on #1577. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ted installation/setup
The current sciprt does not touch the DB.
The UI setup fails, As it attempts to access a user table while at the same time instructing you to create a blank DB. #1572
The SQL is taken from https://github.com/photo/frontend/blob/master/src/configs/upgrade/db/mysql/mysql-base.php#L294-L303.
The script will give you 3 chances to get your password right before providing instructions and SQL to the user on how to manually resolve the db schema issue once they have the password.