Skip to content

Commit

Permalink
Hide xfail/xleak test summary
Browse files Browse the repository at this point in the history
We don't show succeeding tests in the summary, and for all intents and purposes,
these tests have succeeded, in that they behave as expected. I've seen the
output confuse people on multiple occasions, for example GH-17105.

Closes GH-17109
  • Loading branch information
iluuu1994 committed Dec 12, 2024
1 parent cdfd960 commit e7af08d
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions run-tests.php
Original file line number Diff line number Diff line change
Expand Up @@ -3144,18 +3144,6 @@ function get_summary(bool $show_ext_summary): string
$failed_test_summary .= "=====================================================================\n";
}

if (count($PHP_FAILED_TESTS['XFAILED'])) {
$failed_test_summary .= '
=====================================================================
EXPECTED FAILED TEST SUMMARY
---------------------------------------------------------------------
';
foreach ($PHP_FAILED_TESTS['XFAILED'] as $failed_test_data) {
$failed_test_summary .= $failed_test_data['test_name'] . $failed_test_data['info'] . "\n";
}
$failed_test_summary .= "=====================================================================\n";
}

if (count($PHP_FAILED_TESTS['BORKED'])) {
$failed_test_summary .= '
=====================================================================
Expand Down Expand Up @@ -3206,19 +3194,6 @@ function get_summary(bool $show_ext_summary): string
$failed_test_summary .= "=====================================================================\n";
}

if (count($PHP_FAILED_TESTS['XLEAKED'])) {
$failed_test_summary .= '
=====================================================================
EXPECTED LEAK TEST SUMMARY
---------------------------------------------------------------------
';
foreach ($PHP_FAILED_TESTS['XLEAKED'] as $failed_test_data) {
$failed_test_summary .= $failed_test_data['test_name'] . $failed_test_data['info'] . "\n";
}

$failed_test_summary .= "=====================================================================\n";
}

if ($failed_test_summary && !getenv('NO_PHPTEST_SUMMARY')) {
$summary .= $failed_test_summary;
}
Expand Down

0 comments on commit e7af08d

Please sign in to comment.