Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang 19 compilation #2581

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Fix clang 19 compilation #2581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Release 6.0.25 (Not yet released)
-------------
* [Standalone] Changes Passenger (not app) start and stop timeouts to 25s (from 15s) except for Nginx engine mode, which retains a stop timeout of 60s.
* Fixes compilation with clang 19 (latest Fedora update) by dropping a buggy stddev function from the moving average header. Closes GH-2580.
*


Expand Down
6 changes: 0 additions & 6 deletions src/cxx_supportlib/Algorithms/MovingAverage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,6 @@ class DiscExpMovingAverageWithStddev {
double stddev() const {
return sqrt(sumOfSquaredData / dema.sumOfWeights - pow(average(), 2));
}

double stddev(unsigned long long now) const {
DiscExpMovingAverageWithStddev<alpha, alphaTimeUnit, maxAge> copy(*this);
copy.update(0, now);
return sqrt(copy.sumOfSquaredData / copy.sumOfWeights - pow(copy.average(), 2));
}
};


Expand Down
Loading