-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new website for pino #1
base: main
Are you sure you want to change the base?
Conversation
5f6f745
to
0c3f046
Compare
0c3f046
to
f579aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who on the Pino team will maintain this? We have a very simple to maintain website right now. This is much, much, more complicated. Why do we need a whole new website to introduce an improved logo?
If you then need support for maintenance, I can give you a hand 😉, however the site is based on Fastify's, it's all very similar. Surely Pino deserves a new updated site, with dark mode, if you read the documentation in the evenings it is very useful to have it and then it is one of the best loggers in the Node.js world deserves documentation with new graphics 🙂 |
The Fastify org has members that have signed up for maintaining the website because they understand the website project. Speaking for myself, I don't know anything about how this project would be maintained and really don't have the time or interest to figure it out. Why can't the current system be improved? |
Some things are missing in the current system, there is no versioning system in Pino's documentation, I don't think it is possible to include it. Docusaurus makes things very easy to maintain, the important thing is to have a basic knowledge of React, if you like to do frontend then you will enjoy using it. I'm a FullStack Developer is I use React everyday at work, maybe it's easier for me to understand how it works.... depends on knowledge is the willingness to learn new things. In any case, it will be you as Pino's team to evaluate what to do, whether to close the PR or merge it 🙂 no problem for me 😉 |
I don't think we really need that.
I do not.
Not even a little bit.
That's what is happening here. |
I can understand that React does not appeal to everyone 😄, even at work I have noticed this 😄 However, I repeat, no problem for me. 😉 I learned something new and enjoyed it. The same work was also done on Mercurius and a review has already been done in part, I think they really liked the new graphics and the new site. 🙂 I will then see here what decision the pino team will make 🙂 |
f579aac
to
5a04208
Compare
0232207
to
93b190c
Compare
93b190c
to
34e69e3
Compare
issue: pinojs/pino#2055
Some screenshots: