Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187356491
Authored-by: Ryan Wittrup [email protected]
This is the "least-effort" change, which uses the suggestion from George to wrap the existing lager.Logger with a new handler function that is used to convert it into a slog.Logger.
The unit tests are running green, and there are tests in the collaboration_tests which are asserting on the current logging behavior.
For example, in the provision_test:
But that looks to be testing a different "NegroniLogger"
Given that the breaking change relates to a logger used by and within the broker API, it's reasonable that it hasn't been tested by the service broker - that's not really our responsibility