Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps brokerapi from v10 to v11 #277

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

ryanwittrup
Copy link
Contributor

#187356491

Authored-by: Ryan Wittrup [email protected]

This is the "least-effort" change, which uses the suggestion from George to wrap the existing lager.Logger with a new handler function that is used to convert it into a slog.Logger.

The unit tests are running green, and there are tests in the collaboration_tests which are asserting on the current logging behavior.

For example, in the provision_test:

Eventually(loggerBuffer).Should(gbytes.Say(`\[.*\] \d{4}/\d{2}/\d{2} \d{2}:\d{2}:\d{2}\.\d{6} Request PUT /v2/service_instances/some-instance-id Completed 202 in [0-9\.]+.* | Start Time: \d{4}/\d{2}/\d{2} \d{2}:\d{2}:\d{2}\.\d{6}`))

But that looks to be testing a different "NegroniLogger"

Given that the breaking change relates to a logger used by and within the broker API, it's reasonable that it hasn't been tested by the service broker - that's not really our responsibility

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187423493

The labels on this github issue will be updated when the story is started.

coverprofile.out Outdated Show resolved Hide resolved
@ryanwittrup ryanwittrup force-pushed the chore/bump-broker-api-187356491 branch from b8df53a to fc804f8 Compare April 12, 2024 20:43
@abg
Copy link
Member

abg commented Apr 12, 2024

This change overall LGTM.

I just merged the SDK bump a few minutes ago and the ODB pipeline automatically bumped this repo's on-demand-services-sdk dependency.

You'll need to rebase this PR and fix the conflicts as a result.

@ryanwittrup ryanwittrup force-pushed the chore/bump-broker-api-187356491 branch from fc804f8 to 2450b56 Compare April 12, 2024 21:40
@ryanwittrup
Copy link
Contributor Author

Sounds good - for this one I feel like it would be good to talk about a little bit since I want to do a manual test just to see exactly what the differences in the logs are.

So it would be good to hold off on merging until Monday after we get a chance to look it over more

@ryanwittrup ryanwittrup merged commit e558af8 into main Apr 15, 2024
2 checks passed
@ryanwittrup ryanwittrup deleted the chore/bump-broker-api-187356491 branch April 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants