Skip to content

Commit

Permalink
[PC-1502]: Fix tooltip in Chrome
Browse files Browse the repository at this point in the history
Summary: Oops.

Test Plan: `/admin/plugins`, hover the description of a plugin with one that overflows the container. Do the same in both Chrome and Firefox.

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-1502

Signed-off-by: Nick Lanam <[email protected]>

Differential Revision: https://phab.corp.pixielabs.ai/D11240

GitOrigin-RevId: 58627d6
  • Loading branch information
NickLanam authored and copybaranaut committed Apr 16, 2022
1 parent 8ac1562 commit 56c34de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/src/containers/admin/plugins/plugins-overview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const OverflowTooltip: React.FC<{ title: string }> = React.memo(({ title, childr
const spanRef = React.useCallback((el) => setSpan(el), []);

const updateOverflow = React.useCallback(() => {
setOverflow(span?.scrollWidth > span?.parentElement.clientWidth);
setOverflow(span?.parentElement.scrollWidth > span?.parentElement.clientWidth);
}, [span]);

return (
Expand Down

0 comments on commit 56c34de

Please sign in to comment.