Display ORCID Icon only when authenticated #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that to display the ORCID icon only when the user is authenticated, we need to add a condition, similar to what we have for the default theme. (https://github.com/pkp/ojs/blob/7e803f98b0fc90679e796eee69a9bfbed67849d4/templates/frontend/objects/article_details.tpl#L132) ref: https://github.com/pkp/ojs/pull/3865/files
|
@kaitlinnewson, could you have a look at this one? |
|
Hi @kaitlinnewson, I documented here pkp/pkp-lib#9912 that we would need to take a look at all theme plugins, to integrate the new ORCID icon properly, in the same way as in article_details.tpl in the defualt theme. So if you would like to take a look at them all now it would be great, but it can also stay for later -- it is documented in that issue so that we do not forget it before 3.5 :-) |
|
Hi @mhvezina, thanks for the PR! I made a small addition to add styling to the icon, and will go ahead and merge this. |
kaitlinnewson
added a commit
that referenced
this pull request
Aug 13, 2024
* Display ORCID Icon only when authenticated * orcid icon styles --------- Co-authored-by: Kaitlin Newson <[email protected]>
kaitlinnewson
added a commit
that referenced
this pull request
Aug 13, 2024
* Display ORCID Icon only when authenticated * orcid icon styles --------- Co-authored-by: Kaitlin Newson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not wrong, in order to display the ORCID icon only when the user is authenticated, we need to add a condition, similar to what we have for the default theme. Thank you.
ref: pkp/ojs#3865