3.5.0 compatibility #236
3.5.0 compatibility #236
Conversation
kaitlinnewson
force-pushed
the
3.5.0-compatibility
branch
2 times, most recently
from
c77ec2b to
57ffa52
Compare
kaitlinnewson
force-pushed
the
3.5.0-compatibility
branch
from
57ffa52 to
f6a9c0e
Compare
There was a problem hiding this comment.
Thanks, @kaitlinnewson, lots of good tweaks here. Just a few comments to check on.
| @@ -166,15 +173,18 @@ | |||
| {if $author->getLocalizedAffiliation()} | |||
| <div class="article-author-affiliation"> | |||
| {$author->getLocalizedAffiliation()|escape} | |||
| {if $author->getData('rorId')} | |||
| <a href="{$author->getData('rorId')|escape}">{$rorIdIcon}</a> | |||
There was a problem hiding this comment.
This is subject to change based on @GaziYucel's active work on RORs and multiple affiliations.
There was a problem hiding this comment.
Yes, I'm keeping an eye on that issue and can either wait to merge the theme updates or do another PR once that has been merged.
| <div class="orcid"> | ||
| {if $author->getData('orcidAccessToken')} | ||
| {$orcidIcon} | ||
| {/if} | ||
| <a href="{$author->getOrcid()|escape}" target="_blank"> | ||
| {$author->getOrcid()|escape} | ||
| <a href="{$author->getData('orcid')|escape}" target="_blank"> |
There was a problem hiding this comment.
Worth pinging @ewhanson to see how this might change with his nearly-complete ORCiD work.
There was a problem hiding this comment.
I think this is already compliant with ORCID move to the core -- I am not sure, but I think the way orcid is displayed should not change any more, but maybe to double check. If it changes, it will change in the core and then also themes need to be considered (again)...
There was a problem hiding this comment.
I confirmed with @ewhanson that there aren't further changes planned to ORCID for 3.5 that will impact the templates.
No description provided.