Make links work when opened in a new tab using right click context menu

[ibnesayeed]

This is an attempt to fix play-with-docker/play-with-docker.github.io#126, but not tested well.

[ibnesayeed]

Now, I have tested it and it seems to be working as expected.

[ibnesayeed]

@marcosnils I added the following line in the index.html file temporarily to test my changes:

<a href="/foo/bar?baz=blah" data-term="#myTerm" data-port="80">Click Here</a>

[marcosnils]

@ibnesayeed still doesn't work in my case. If you go to the Docker for beginners tutorial and try to left click the click here link in a new tab it still doesn't work 😞

[ibnesayeed]

@marcosnils how did you try to test on the training site while these changes are not reflected there yet? The live site is using RawGit CDN from the dist directory. That means in order for it to be effective there, the change here needs to be merged and the dist files are to be regenerated. If you have any other means of testing it on the training site then I am not aware of that.

[ibnesayeed]

The RawGit CDN used by the PWD to serve the SDK files is sunsetting. play-with-docker/play-with-docker.github.io#166

[marcosnils]

@marcosnils how did you try to test on the training site while these changes are not reflected there yet?

@ibnesayeed just tried it again and it's not working for me. To test it locally I just serve the pwd.js from my macine using the README instructions in the repo and I change the _layouts/post.html (https://github.com/play-with-docker/play-with-docker.github.io/blob/master/_layouts/post.html#L53) and point it to http://localhost:8080/dist/pwd.js.

[ibnesayeed]

Serving /dist/pwd.js will not work until the dist is rebuilt because changes are made in the index.js file.

[marcosnils]

You can run `npm run build ` to generate the PWD.js built file. sent from mobile El sáb., 27 oct. 2018 19:52, Sawood Alam <[email protected]> escribió:

…

Serving /dist/pwd.js will not work until the dist is rebuilt because changes are made in the index.js file. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABgV2kwzLEMpuDya5RbjmZz9sFEDW1YFks5upOOpgaJpZM4W3yXK> .

[ibnesayeed]

Yes, that's how I tested it locally earlier, but I thought you were missing that as you said it was not working for you while it does for me.

[marcosnils]

What it wasn't working for me has the middle button click, on the right button. In any case it should work for all cases now sent from mobile El sáb., 27 oct. 2018 20:38, Sawood Alam <[email protected]> escribió:

…

Yes, that's how I tested it locally earlier, but I thought you were missing that as you said it was not working for you while it does for me. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABgV2jtrbF_mYlUi1czr8g9a6qwlQ0KLks5upO52gaJpZM4W3yXK> .

[Deifinger]

It works well. Thank you guys @marcosnils @ibnesayeed