Add Show Compare Profile UI * #2718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehkuznetsov
requested changes
Sep 9, 2019
| /// <summary> | ||
| /// Shows the Play Games Player Profile UI for a specific player. | ||
| /// </summary> | ||
| /// <param name="userId">User identifier. It cannot be null. </param> |
There was a problem hiding this comment.
No need to specify "It cannot be null"
| /// <summary> | ||
| /// Shows the Player Profile UI for the given player Id | ||
| /// </summary> | ||
| /// <param name="userId">User Identifier. It cannot be null.</param> |
There was a problem hiding this comment.
No need to specify which param can or which can't be null
| @@ -713,6 +713,28 @@ public void ReportProgress(string achievementID, double progress, Action<bool> c | |||
| }); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Shows the Player Profile UI for the given player Id | |||
| /// Shows the Play Games Player Profile UI for a specific player. | ||
| /// </summary> | ||
| /// <param name="userId">User identifier. It cannot be null. </param> | ||
| /// <param name="callback">Callback.</param> |
There was a problem hiding this comment.
Callback.
Check how we describe 'callback' in other methods, please.
redls
force-pushed
the
android-java-client
branch
from
00e373b to
ad22443
Compare
olehkuznetsov
requested changes
Sep 9, 2019
| }); | ||
| AndroidTaskUtils.AddOnFailureListener(task, exception => | ||
| { | ||
| InvokeCallbackOnGameThread(callback, UIStatus.NotAuthorized); |
There was a problem hiding this comment.
UIStatus.NotAuthorized probably there are more cases it could faild and most frequent one will be no internet connection.
We should get status code from ApiException and switch over possible status codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.