fix: handle empty title when not passed to icon and update snapshots

plone · Sep 27, 2024 · e00e5a0 · e00e5a0
1 parent 0de063b
commit e00e5a0
Show file tree

Hide file tree

Showing 55 changed files with 319 additions and 41 deletions.
diff --git a/packages/volto/src/components/manage/BlockChooser/__snapshots__/BlockChooser.test.jsx.snap b/packages/volto/src/components/manage/BlockChooser/__snapshots__/BlockChooser.test.jsx.snap
@@ -40,6 +40,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -65,6 +66,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button image"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -78,6 +80,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button listing"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -91,6 +94,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button video"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -109,6 +113,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -134,6 +139,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button text"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -152,6 +158,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -177,6 +184,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button image"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -190,6 +198,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button leadimage"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -203,6 +212,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button video"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -221,6 +231,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -246,6 +257,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button listing"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -259,6 +271,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button toc"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -272,6 +285,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button hero"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -285,6 +299,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button maps"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -298,6 +313,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button html"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -311,6 +327,7 @@ exports[`BlocksChooser Fallback BlockChooser component onMutateBlock 1`] = `
                 class="ui basic icon button table"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -365,6 +382,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -390,6 +408,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button image"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -403,6 +422,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button listing"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -416,6 +436,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button video"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -434,6 +455,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -459,6 +481,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button text"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -477,6 +500,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -502,6 +526,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button image"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -515,6 +540,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button leadimage"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -528,6 +554,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button video"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -546,6 +573,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
           class="accordion-tools"
         >
           <svg
+            aria-label=""
             class="icon"
             style="height: 20px; width: auto; fill: currentColor;"
             viewBox=""
@@ -571,6 +599,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button listing"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -584,6 +613,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button toc"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -597,6 +627,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button hero"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -610,6 +641,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button maps"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -623,6 +655,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button html"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />
@@ -636,6 +669,7 @@ exports[`BlocksChooser renders a BlockChooser component 1`] = `
                 class="ui basic icon button table"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 36px; width: auto; fill: currentColor;"
                 />

diff --git a/...s/volto/src/components/manage/BlockChooser/__snapshots__/BlockChooserButton.test.jsx.snap b/...s/volto/src/components/manage/BlockChooser/__snapshots__/BlockChooserButton.test.jsx.snap
@@ -17,6 +17,7 @@ exports[`Renders a button 1`] = `
     title="Add block"
   >
     <svg
+      aria-label=""
       class="icon block-add-button"
       style="height: 19px; width: auto; fill: currentColor;"
       viewBox=""

diff --git a/packages/volto/src/components/manage/Blocks/Block/__snapshots__/BlocksForm.test.jsx.snap b/packages/volto/src/components/manage/Blocks/Block/__snapshots__/BlocksForm.test.jsx.snap
@@ -33,6 +33,7 @@ exports[`Allow override of blocksConfig 1`] = `
               tabindex="0"
             >
               <svg
+                aria-label=""
                 class="icon"
                 style="height: 18px; width: auto; fill: currentColor;"
                 viewBox=""
@@ -59,6 +60,7 @@ exports[`Allow override of blocksConfig 1`] = `
                 class="ui basic icon button delete-button"
               >
                 <svg
+                  aria-label=""
                   class="icon"
                   style="height: 18px; width: auto; fill: currentColor;"
                   viewBox=""
@@ -87,6 +89,7 @@ exports[`Allow override of blocksConfig 1`] = `
               tabindex="0"
             >
               <svg
+                aria-label=""
                 class="icon"
                 style="height: 18px; width: auto; fill: currentColor;"
                 viewBox=""
@@ -156,6 +159,7 @@ exports[`Allow override of blocksConfig 1`] = `
             tabindex="0"
           >
             <svg
+              aria-label=""
               class="icon"
               style="height: 16px; width: auto; fill: currentColor;"
               viewBox=""
@@ -172,6 +176,7 @@ exports[`Allow override of blocksConfig 1`] = `
             tabindex="0"
           >
             <svg
+              aria-label=""
               class="icon"
               style="width: auto; fill: currentColor;"
               viewBox=""
@@ -218,6 +223,7 @@ exports[`Allow override of blocksConfig 1`] = `
             tabindex="0"
           >
             <svg
+              aria-label=""
               class="icon"
               style="height: 16px; width: auto; fill: currentColor;"
               viewBox=""
@@ -234,6 +240,7 @@ exports[`Allow override of blocksConfig 1`] = `
             tabindex="0"
           >
             <svg
+              aria-label=""
               class="icon"
               style="width: auto; fill: currentColor;"
               viewBox=""

diff --git a/packages/volto/src/components/manage/Blocks/Image/__snapshots__/ImageSidebar.test.jsx.snap b/packages/volto/src/components/manage/Blocks/Image/__snapshots__/ImageSidebar.test.jsx.snap
@@ -17,6 +17,7 @@ Array [
         title="Clear image"
       >
         <svg
+          aria-label=""
           className="icon"
           dangerouslySetInnerHTML={
             Object {

diff --git a/...volto/src/components/manage/Blocks/LeadImage/__snapshots__/LeadImageSidebar.test.jsx.snap b/...volto/src/components/manage/Blocks/LeadImage/__snapshots__/LeadImageSidebar.test.jsx.snap
@@ -68,6 +68,7 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
                   onClick={[Function]}
                 >
                   <svg
+                    aria-label=""
                     className="icon"
                     dangerouslySetInnerHTML={
                       Object {
@@ -96,6 +97,7 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
                   onClick={[Function]}
                 >
                   <svg
+                    aria-label=""
                     className="icon"
                     dangerouslySetInnerHTML={
                       Object {
@@ -124,6 +126,7 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
                   onClick={[Function]}
                 >
                   <svg
+                    aria-label=""
                     className="icon"
                     dangerouslySetInnerHTML={
                       Object {
@@ -152,6 +155,7 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
                   onClick={[Function]}
                 >
                   <svg
+                    aria-label=""
                     className="icon"
                     dangerouslySetInnerHTML={
                       Object {
@@ -186,6 +190,7 @@ exports[`renders a Lead Image block Sidebar component 1`] = `
     >
       Link Settings
       <svg
+        aria-label=""
         className="icon"
         dangerouslySetInnerHTML={
           Object {

diff --git a/...src/components/manage/Blocks/Search/components/__snapshots__/DateRangeFacet.test.jsx.snap b/...src/components/manage/Blocks/Search/components/__snapshots__/DateRangeFacet.test.jsx.snap
@@ -86,6 +86,7 @@ exports[`DateRangeFaceg renders a facet component with a date range widget 1`] =
                 type="button"
               >
                 <svg
+                  aria-label=""
                   class="icon close"
                   style="height: 24px; width: auto; fill: currentColor;"
                   viewBox=""

diff --git a/...lto/src/components/manage/Blocks/Search/components/__snapshots__/FilterList.test.jsx.snap b/...lto/src/components/manage/Blocks/Search/components/__snapshots__/FilterList.test.jsx.snap
@@ -12,6 +12,7 @@ exports[`FilterList renders filters listing component for search block 1`] = `
       className="filter-list-title"
     >
       <svg
+        aria-label=""
         className="icon"
         dangerouslySetInnerHTML={
           Object {