Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase contrast in table block for a11y reasons #6333

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Increase contrast in table block for a11y reasons #6333

merged 6 commits into from
Sep 27, 2024

Conversation

jackahl
Copy link
Member

@jackahl jackahl commented Sep 26, 2024 •
edited
Loading

fix for #2487 and #6334

@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 648b2b4
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f5428601d26e0008c7de4e

@jackahl jackahl changed the title Increase specificity of table header style selector Increase contrast in table block for a11y reasons Sep 26, 2024
@JeffersonBledsoe JeffersonBledsoe requested review from a team and removed request for JeffersonBledsoe September 26, 2024 10:38
@JeffersonBledsoe
Copy link
Member

JeffersonBledsoe commented Sep 26, 2024 •
edited
Loading

Some details on the change:
Current contrast ratio as tested by WebAIM is 6.66:1 which surpasses the 4.5:1 contrast ratio required for 'normal' size text required by WCAG 2.2 SC 1.4.3 Contrast Minimum (AA). The body text doesn't meet SC 1.4.6 Contrast Enhanced, but I don't see this as an issue as we generally don't aim for AAA.

Screenshot of the PR in it's current state is below.

Screenshot showing light blue text against a dark background

@JeffersonBledsoe JeffersonBledsoe requested review from a team and removed request for JeffersonBledsoe September 26, 2024 12:30
JeffersonBledsoe
JeffersonBledsoe approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JeffersonBledsoe JeffersonBledsoe added the 99 tag: UX Accessibility Accessibility issues label Sep 26, 2024
@pnicolli pnicolli merged commit 47886f8 into main Sep 27, 2024
71 checks passed
@pnicolli pnicolli deleted the table-block-contrast branch September 27, 2024 23:17
This was referenced Sep 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffersonBledsoe JeffersonBledsoe JeffersonBledsoe approved these changes

@pnicolli pnicolli pnicolli approved these changes

@sneridagh sneridagh Awaiting requested review from sneridagh

Assignees
No one assigned
Labels
99 tag: UX Accessibility Accessibility issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackahl @JeffersonBledsoe @pnicolli