-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document routes API #6604
Document routes API #6604
Conversation
✅ Deploy Preview for plone-components canceled.
|
Bringing the conversation here to keep it together with its PR.
OK, I forgot we have https://plone-registry.readthedocs.io/, so we can put it there. However, if I don't want to add a "canary" section to the current Plone 6 docs. I'd rather create a new branch I need to add pull request previews for this repo. I think I can do it, but it could be tricky. I'll try to review in the next couple of nights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how-to-guides/register-routes
needs to be added to /index.md
.
I had to make a release of Plone Sphinx Theme to fix the display of the icon in the admonition. See pydata/pydata-sphinx-theme#2099 I then added support for I also added the new page to And we now have pull request previews for the docs. However the slug in the URL that gets written back in the pull request description is for Volto, not https://plone-registry--6604.org.readthedocs.build/how-to-guides/register-routes.html Please take a look, and let me know. |
@macagua https://www.rietveldschroderhuis.nl/en is not loading, and you added it in https://github.com/collective/awesome-volto/blame/4332d4158d517802f8532c6966f7c30f05206f0d/README.md#L227. It appears to be a site created by INTK. @andreesg @ruibeep @simonbrunel from INTK, I found your GitHub usernames from the INTK GitHub organization, and assume that you will soon be aware of the downtime when you wake up this morning. https://github.com/intk/intk-upptime?tab=readme-ov-file For us in Volto, we can ignore this readme linkcheck warning for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I purged the now unnecessary togglebutton extension and config.
I also fiddled with the wording and grammar.
Co-authored-by: Steve Piercy <[email protected]>
The site https://www.rietveldschroderhuis.nl/ has been down for at least 3 days, it causes a CI job to fail in Volto, the owners have not responded, and they removed the site from their monitoring repo. Let's give them one more day to respond, then merge if they do not. See plone/volto#6604 (comment) @cihanandac @andreesg @ruibeep @simonbrunel
📚 Documentation preview 📚: https://volto--6604.org.readthedocs.build/