Clustergram: app improvements #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shammamah-zz
changed the title
…ta and converts arrays to lists.
…e clustergram is recomputed every time.
…ed to the tsv reader.
Closed
…splaying the clustergrams.
… for iris dataset.
…re-loaded datasets.
Bachibouzouk
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
- I like the color scheme !
- you could maybe place the "Columns to display" and "Rows to display" at the end of the option list as their size can vary significantly, so the layout of the other options stays relatively the same :)
- you could also add a
titleprop for the "Add or remove all group markers:" div to explain how to use it and what it does :)
I'll approve the PR so you can have the latest version ready for the demo and because the changes I suggest are only improvements :)
| # they must be converted back | ||
| if(isinstance(xs, list)): | ||
| xs = [x if x is not None else np.nan for x in xs] | ||
| xs = np.array(xs) |
There was a problem hiding this comment.
In terms of speed looping explicitely over arrays in python is slover than using pandas or numpy functions, it would only be important for superlarge datasets though
| xs = t['row'][i]['x'] | ||
| ys = t['row'][i]['y'] | ||
|
|
||
| if(isinstance(xs, list)): |
There was a problem hiding this comment.
almost the same code as above but with 'row' instead of 'col', could be done in a function for easier maintenance
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #64.