Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideogram: App Improvements #71

Merged
merged 12 commits into from
Dec 6, 2018
Merged

Ideogram: App Improvements #71

merged 12 commits into from
Dec 6, 2018

Conversation

mtwichan
Copy link
Contributor

@mtwichan mtwichan commented Dec 4, 2018

Dash Bio pull request

  • This is a new component
  • I am adding a feature to an existing component

Name and description of your component

Main libraries used in component

  • Make sure you add links!

Before asking for a review

PR merging checklist

Please make sure you have done these things before asking for approval to finally merge.

  • Address all comments in the code review.
  • Make sure you are up-to-date with the latest master: checkout the master branch with git checkout master, pull from latest master git pull, checkout to your branch git checkout your-branch, merge master into your branch git merge master. Resolve conflicts.
  • Update/regenerate package-lock.json (run npm install)
  • Ensure that your requirements.txt is complete
  • Rebuild (run npm run build:all or npm run build:js followed by npm run build:py
  • Regenerate tarball (run python setup.py sdist, then copy dist/dash_bio-X.Y.Z.tar.gz into the top-level directory)
  • Ensure that you installed the tarball you generated with the above commands (run pip install dash-bio-X.Y.Z.tar.gz)
  • Run your application successfully in a virtual environment and test that other apps still run
  • Commit and push the files that were generated in the dash-bio folder by the above command(s)
  • Ask for a final review and look for a 💃!
  • Have your dancer? Merge to master!

DDS Deployment

  • Get the developers user credentials from a dash-bio team member.
  • Checkout the master branch of the dash-bio repository, make sure you have the latest master (git pull).
  • Check remotes associated to your repository: git remote -v, make sure you have the dash-bio one: https://dash-gallery.plotly.host/GIT/dash-bio.
  • If you don't have the dash-bio remote add it with https, ssh will not work: git remote add dash-bio https://dash-gallery.plotly.host/GIT/dash-bio.
  • You will be asked to enter the developers user credentials, have them ready.
  • Push local master to the dds dash-bio master: git push dash-bio master.

DDS Deployment Debugging

  • If running git push dash-bio master you may encounter the following issue:
remote: User <username> does not have permissions to run git-hook on dash-bio, or dash-bio does not exist
remote: Access denied
To https://dash-gallery.plotly.host/GIT/dash-bio
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://dash-gallery.plotly.host/GIT/dash-bio'

This may be because the git credentials are saved on the client-side. In order to solve this, do the following:

Windows

Go to: Control Panel -> User Accounts -> Manage your credentials -> Windows Credentials -> Under Generic Credentials find: git:https://dash-gallery.plotly.host -> Remove credential OR edit username/password to provided account.

OS X

Go to: Keychain Access -> Search for dash-gallery.plotly.host -> Change "Account" to "developers" -> Click on "show password" -> Change the password to the one provided -> Click "Save Changes". 

resolve: #60

@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-71 December 4, 2018 20:04 Inactive
@mtwichan
Copy link
Contributor Author

mtwichan commented Dec 4, 2018

Addresses: #64

@Bachibouzouk Bachibouzouk self-requested a review December 5, 2018 10:14
Copy link
Contributor

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inputs in the homology tab are cut by the scroll bar, either reduce their size or increase the option div size.

@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-71 December 5, 2018 23:15 Inactive
@mtwichan
Copy link
Contributor Author

mtwichan commented Dec 5, 2018

@Bachibouzouk fixed!

Bachibouzouk
Bachibouzouk previously approved these changes Dec 6, 2018
Copy link
Contributor

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Chr Height" could be replaced by "Chr Lenght" so that it works for both horizontal and vertical display ;), but merge the PR before making more changes so that your other changes can be seen at the demo today :)

@mtwichan
Copy link
Contributor Author

mtwichan commented Dec 6, 2018

@Bachibouzouk for Chr Height this is actually a prop in the component itself, which is listed in the API as Chr Height

@mtwichan
Copy link
Contributor Author

mtwichan commented Dec 6, 2018

@Bachibouzouk for Chr Height this is actually a prop in the component itself, which is listed in the API as Chr Height.

2 similar comments
@mtwichan
Copy link
Contributor Author

mtwichan commented Dec 6, 2018

@Bachibouzouk for Chr Height this is actually a prop in the component itself, which is listed in the API as Chr Height.

@mtwichan
Copy link
Contributor Author

mtwichan commented Dec 6, 2018

@Bachibouzouk for Chr Height this is actually a prop in the component itself, which is listed in the API as Chr Height.

@mtwichan mtwichan requested a review from shammamah-zz December 6, 2018 16:40
Copy link
Contributor

@shammamah-zz shammamah-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💃

Copy link
Contributor

@shammamah-zz shammamah-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💃

@mtwichan mtwichan requested a review from shammamah-zz December 6, 2018 16:43
Copy link
Contributor

@shammamah-zz shammamah-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💃

@shammamah-zz
Copy link
Contributor

💃

@mtwichan mtwichan merged commit 0d86f30 into master Dec 6, 2018
@mtwichan mtwichan deleted the ideogram-review-fix branch December 6, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Ideogram
3 participants