fix Plot.show() (#131)

* fix Plot.show() Closes #128 * Update plot.rs * Update plot.rs * Update plot.rs
plotly · Jan 9, 2023 · 8903ff0 · 8903ff0
1 parent bec81a3
commit 8903ff0
Showing 1 changed file with 15 additions and 9 deletions.
diff --git a/plotly/src/plot.rs b/plotly/src/plot.rs
@@ -262,10 +262,13 @@ impl Plot {
 
         // Save the rendered plot to the temp file.
         let temp_path = temp.to_str().unwrap();
-        let mut file = File::create(temp_path).unwrap();
-        file.write_all(rendered.as_bytes())
-            .expect("failed to write html output");
-        file.flush().unwrap();
+
+        {
+            let mut file = File::create(temp_path).unwrap();
+            file.write_all(rendered.as_bytes())
+                .expect("failed to write html output");
+            file.flush().unwrap();
+        }
 
         // Hand off the job of opening the browser to an OS-specific implementation.
         Plot::show_with_default_app(temp_path);
@@ -288,10 +291,13 @@ impl Plot {
 
         // Save the rendered plot to the temp file.
         let temp_path = temp.to_str().unwrap();
-        let mut file = File::create(temp_path).unwrap();
-        file.write_all(rendered.as_bytes())
-            .expect("failed to write html output");
-        file.flush().unwrap();
+
+        {
+            let mut file = File::create(temp_path).unwrap();
+            file.write_all(rendered.as_bytes())
+                .expect("failed to write html output");
+            file.flush().unwrap();
+        }
 
         // Hand off the job of opening the browser to an OS-specific implementation.
         Plot::show_with_default_app(temp_path);
@@ -467,7 +473,7 @@ impl Plot {
         Command::new("cmd")
             .arg("/C")
             .arg(format!("start {}", temp_path))
-            .spawn()
+            .output()
             .expect(DEFAULT_HTML_APP_NOT_FOUND);
     }
 }