Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: entra roledefinition set. Closes #6467 #6522

Closed
wants to merge 5 commits into from
Closed

New command: entra roledefinition set. Closes #6467 #6522

wants to merge 5 commits into from

Conversation

MartinM85
Copy link
Contributor

Closes #6467

@milanholemans
Copy link
Contributor

Thank you @MartinM85, we'll try to review it ASAP.

@martinlingstuyl martinlingstuyl self-assigned this Jan 9, 2025
martinlingstuyl
martinlingstuyl requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments @MartinM85. Nice work!

docs/docs/cmd/entra/roledefinition/roledefinition-set.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/roledefinition/roledefinition-set.mdx Outdated Show resolved Hide resolved
src/m365/entra/commands/roledefinition/roledefinition-set.ts Outdated Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft January 9, 2025 21:03
@MartinM85 MartinM85 marked this pull request as ready for review January 10, 2025 07:06
martinlingstuyl
martinlingstuyl approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, approved. Just one small thing to fix last, but I can do that while merging...

@martinlingstuyl
Copy link
Contributor

Merged manually, thank you 🥳🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: entra roledefinition set
3 participants
@MartinM85 @milanholemans @martinlingstuyl