Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Form] Fix for 1788/1794 and add styles property for support customizing styling #1913

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

wuxiaojun514
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [x]
New sample? [ ]
Related issues? fixes #1788 , partially #1794

What's in this Pull Request?

This PR is mainly for

I have documented the new feature on DynamicForm.md and given an example how to overwrite styling

I know it is quite a big change, please let me know if anything missing.

Guidance

  • You can delete this section when you are submitting the pull request.
  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to dev branch.

@wuxiaojun514
Copy link
Contributor Author

Hi @joelfmrodrigues , could you look into it if you have some time?
This PR is for fixing two bugs (#1788 ,#1794 ) on Dynamic Form when list has enabled section layout and introduced className and styles property on this control so developer can customize the styling on it.
I also updated the related documentation for the new feature.
This PR changed quite a lot of code so it is very easy to have conflict with other submission ( I already fixed the conflicts two times), so I hope it can be reviewed early...
Please contact me if anything unclear or I need modify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant