Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Тимофеев Кирилл, ИТМО DWS, Stage 5 #171

Merged
merged 60 commits into from
May 10, 2024
Merged

Тимофеев Кирилл, ИТМО DWS, Stage 5 #171

merged 60 commits into from
May 10, 2024

Conversation

NoGe4Ek
Copy link
Contributor

@NoGe4Ek NoGe4Ek commented Apr 10, 2024 •
edited
Loading

Ready

NoGe4Ek and others added 30 commits February 20, 2024 23:25
@NoGe4Ek
add scratch
ff5d54a
@NoGe4Ek
task 1
556d022 
add impl with report
@NoGe4Ek
task 1
56fb7e6 
fix readme and ApplicationServer refactor
@NoGe4Ek
task 1
84f4a21 
fix readme
@NoGe4Ek
task 1
aed8a67 
fix readme; code refactor
@NoGe4Ek
task 1
2ca29d4 
code refactor
@NoGe4Ek
task 1
5e7d22d 
fix empty value
@incubos
Merge branch 'main' into feature/task1
78d545e
@NoGe4Ek
Merge branch 'polis-vk:main' into feature/task1
0411733
@NoGe4Ek
Merge branch 'main' into feature/task2
e3b9f99
@NoGe4Ek
task 2
0225f8a 
add thread pool executor
fix comments for task 1
@NoGe4Ek
task 2
bd639b4 
refactor
@NoGe4Ek
task 2
44ac9e8 
refactor
@NoGe4Ek
task 2
d22b117 
refactor
@NoGe4Ek
task 2
5d47f5b 
fix review comments:
add shutdownAndAwaitTermination
add prestartAllCoreThreads
@NoGe4Ek
task 2
eb15ec7 
fix stage
@NoGe4Ek
task 2
bcb8433 
report
@NoGe4Ek
task 2
2cec7fe 
fixes after review
@NoGe4Ek
task 2
19f0548 
fixes after review
@NoGe4Ek
Merge remote-tracking branch 'origin/main' into feature/task3
d85275d
@NoGe4Ek
task 3
8548fca 
add rendezvous sharding
@NoGe4Ek
task 3
29d33fe 
fix codestyle
@NoGe4Ek
task 3
d1eaaff 
fix codestyle
@NoGe4Ek
task 3
0279872 
fix codestyle
@NoGe4Ek
task 3
2552ed4 
add empty files
@NoGe4Ek
task 3
4fe0431 
add cluster
fix hashing algorithm
add report
@NoGe4Ek
task 3
5dad83c 
add png + fix readme
@NoGe4Ek
task 4
e2bb50e 
first template
@NoGe4Ek
Merge remote-tracking branch 'origin/main' into feature/task4
e334599 
# Conflicts:
#	src/main/java/ru/vk/itmo/test/timofeevkirill/ApplicationServer.java
#	src/main/java/ru/vk/itmo/test/timofeevkirill/Settings.java
#	src/main/java/ru/vk/itmo/test/timofeevkirill/TimofeevServer.java
#	src/main/java/ru/vk/itmo/test/timofeevkirill/TimofeevService.java
@NoGe4Ek
task 4
e87321d 
refactor
@NoGe4Ek
task 5
9fe55dd 
refactor code
@incubos incubos requested a review from vladimir-bf April 13, 2024 12:47
codeclimate[bot]
codeclimate bot reviewed Apr 15, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114683 lines exceeds the maximum allowed for the inline comments feature.

@NoGe4Ek
task 5
334ea70 
fix readme
codeclimate[bot]
codeclimate bot reviewed Apr 15, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114683 lines exceeds the maximum allowed for the inline comments feature.

@vladimir-bf vladimir-bf assigned incubos and unassigned vladimir-bf Apr 24, 2024
codeclimate[bot]
codeclimate bot reviewed Apr 28, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114683 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Apr 30, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114683 lines exceeds the maximum allowed for the inline comments feature.

incubos
incubos requested changes May 1, 2024
View reviewed changes
Copy link
Member

@incubos incubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть существенные замечания и вопросы, в т.ч. к отчёту -- ждём исправлений.

src/main/java/ru/vk/itmo/test/timofeevkirill/reference/MergeHandleResult.java Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/reference/ReferenceServer.java Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/reference/ReferenceServer.java Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/reference/ReferenceServer.java Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/reference/ReferenceServer.java Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/results/task5/readme.md Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/results/task5/readme.md Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/results/task5/readme.md Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/results/task5/readme.md Outdated Show resolved Hide resolved
src/main/java/ru/vk/itmo/test/timofeevkirill/results/task5/readme.md Outdated Show resolved Hide resolved
@NoGe4Ek
Copy link
Contributor Author

NoGe4Ek commented May 3, 2024 •
edited
Loading

Есть существенные замечания и вопросы, в т.ч. к отчёту -- ждём исправлений.

Исправил замечания. По отчету действительно были проблемы, тк получилось снять аномальные профили и не было достаточно времени, чтобы анализировать проблемы. Частично это связано с тем, что для синхронной реализации пришлось заново собирать профили, что требует доп. времени на этапе.
Постарался поискать причины аномалий и дополнил отчет анализом.

@NoGe4Ek
task 6
7972e05 
6 task fixes
codeclimate[bot]
codeclimate bot reviewed May 3, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114705 lines exceeds the maximum allowed for the inline comments feature.

@NoGe4Ek
task 6
aae3cd6 
fix code climate
codeclimate[bot]
codeclimate bot reviewed May 3, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114704 lines exceeds the maximum allowed for the inline comments feature.

@incubos incubos removed the request for review from vladimir-bf May 10, 2024 16:48
codeclimate[bot]
codeclimate bot reviewed May 10, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 114704 lines exceeds the maximum allowed for the inline comments feature.

incubos
incubos approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@incubos incubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 баллов.

src/main/java/ru/vk/itmo/test/timofeevkirill/results/task5/readme.md
SchedulableTask.run() - по идее класс отвечает за постановку задач в очередь на потоки. Насколько я понимаю, он помогает
в обработке цепочек в completable future. Единственное, чего я не понимаю - это почему он такой же большой для sync флейм графа.

Появился ForkJoinWorkerThread. Он отвечает за выполнение ForkJoinTask CompletableFuture.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Откуда этот FJP? Он нам нужен? Можем от него избавиться? Запускать свои задачи в common default FJP так себе идея.

@incubos incubos merged commit 780d69f into polis-vk:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@incubos incubos incubos approved these changes

Assignees

@incubos incubos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoGe4Ek @incubos @vladimir-bf @pashchenko8