HW 5 Шишигин Степан DWS ИТМО #197

sshishigin · 2024-04-16T20:42:02Z

No description provided.

(cherry picked from commit ea6b417)

…equest)

if handled succesfully - send errorcode if handling failed - close connection

src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

incubos

Нужно зарезолвить конфликты.

# Conflicts: # src/main/java/ru/vk/itmo/test/shishiginstepan/lua_scripts/random_rw_requests.lua # src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java # src/main/java/ru/vk/itmo/test/shishiginstepan/server/RemoteDaoNode.java # src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java # src/main/java/ru/vk/itmo/test/shishiginstepan/service/DatabaseService.java

incubos

Есть ряд вопросов и замечаний.

incubos · 2024-05-01T18:56:48Z

src/main/java/ru/vk/itmo/test/shishiginstepan/profiling/profiling5.MD

+Я дуамю что если бы изначально выбрал java http клиент то мог бы провести более качественное сравнение. <br>
+В общем я считаю что задержка запросов могла бы уменьшиться, но ценой большого количества вспомогательных потоков, так что в принципе <br>
+это хороший способ ускорить приложение и утилизировать ресурсы. Но проблемы с синхронизацией потоков могут повлиять <br>
+( и сильно повлияли) на работоспособность системы, так как увеличилось количество блокировок.


Что за проблемы с синхронизацией потоков? Где видно влияние "на работоспособность системы"? Звучит очень абстрактно.
В итоге throughput упал, а latency не изменились?

incubos · 2024-05-01T18:59:02Z

src/main/java/ru/vk/itmo/test/shishiginstepan/profiling/profiling5.MD

+### PUT запросы
+##### СPU
+![](profiling_artifacts_5/putCPU.png)
+
+##### ALLOC
+![](profiling_artifacts_5/putAlloc.png)
+
+
+### GET запросы
+##### СPU
+![](profiling_artifacts_5/getCpu.png)
+
+##### ALLOC
+![](profiling_artifacts_5/getAlloc.png)


Профили нужны интерактивные в .html.

incubos · 2024-05-01T19:01:02Z

src/main/java/ru/vk/itmo/test/shishiginstepan/profiling/profiling5.MD

+## Выводы
+
+Я дуамю что если бы изначально выбрал java http клиент то мог бы провести более качественное сравнение. <br>
+В общем я считаю что задержка запросов могла бы уменьшиться, но ценой большого количества вспомогательных потоков, так что в принципе <br>


А вы пробовали увеличить количество потоков? Если становится только лучше, то почему бы и нет.

incubos · 2024-05-01T19:05:57Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java

-                (e1, e2) -> -e1.timestamp().compareTo(e2.timestamp())
-        );
+
+        var resultHandler = new MergeResultHandler(shouldAck, requestFrom, session);


Этот внезапный var заметно выбивается из общего стиля...

incubos · 2024-05-01T19:11:39Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java

+        Integer shouldAck = ack == null ? quorum : ack;
+        Integer requestFrom = from == null ? totalNodes : from;


Почему здесь Integer, а не int? Даже IDEA подсказывает.

incubos · 2024-05-01T19:41:49Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

+                processors + 1,
+                processors + 1,


Почему +1?

incubos · 2024-05-01T19:42:18Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

@@ -74,6 +59,7 @@ private static HttpServerConfig configFromServiceConfig(ServiceConfig serviceCon
        AcceptorConfig acceptorConfig = new AcceptorConfig();
        acceptorConfig.reusePort = true;
        acceptorConfig.port = serviceConfig.selfPort();
+        serverConfig.selectors = Runtime.getRuntime().availableProcessors() / 2;


Все эти Runtime.getRuntime().availableProcessors() / 2 должны стать константами с говорящими именами.

incubos · 2024-05-01T19:42:38Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

                }
            });
+


Suggested change

incubos · 2024-05-01T19:48:37Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

+            Long timestamp = Long.parseLong(request.getHeader(TIMESTAMP_HEADER));
+            EntryWithTimestamp<MemorySegment> entry = new EntryWithTimestamp<>(
+                    key,
+                    MemorySegment.ofArray(request.getBody()), timestamp


Suggested change

MemorySegment.ofArray(request.getBody()), timestamp

MemorySegment.ofArray(request.getBody()),

timestamp

incubos · 2024-05-01T19:49:17Z

src/main/java/ru/vk/itmo/test/shishiginstepan/server/Server.java

+            session.sendResponse(
+                    response
+            );


Suggested change

session.sendResponse(

response

);

session.sendResponse(response);

incubos

10 баллов.

Степан and others added 30 commits February 19, 2024 23:59

dao init

294e3c7

service init

e960631

server init

229b790

lua random read write delete script

4e01c45

codestyle fixes

7dfdc2c

codestyle fixes

ba052d6

codestyle fixes

268619c

codestyle fixes

7203e78

codestyle fixes

8a5091b

codestyle fixes

4f67dbf

codestyle fixes

5655638

some dao fixes

d6d663b

lua script fixes

04ace3c

lua script fixes

420a6da

report with artifacts

fff2d0d

Update README.md (polis-vk#42)

83ba322

(cherry picked from commit ea6b417)

mem storage limit increased

af06133

some script refactoring

e88204c

first straightforward solution (executor.execute in overriden handleR…

7c15f5f

…equest)

Merge branch 'main' into stage-2

b1844f4

small refactoring and thread numbers shuffle

a2c72a1

Nonnul annotation missed

8a4c926

logging level in dao

71e98e9

fix checkstyle?

9ecefb3

fix checkstyle?

475bdd2

Merge branch 'main' into stage-2

6b4ec74

Merge remote-tracking branch 'origin/stage-2' into stage-2

ef6deb4

checkstyle

adde554

checkstyle

4d8e176

two-level exception handling

ee7d646

if handled succesfully - send errorcode if handling failed - close connection

code climate

89b57bf

codeclimate bot reviewed Apr 16, 2024

View reviewed changes

code climate

f5026de

codeclimate bot reviewed Apr 16, 2024

View reviewed changes

src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java Outdated Show resolved Hide resolved

src/main/java/ru/vk/itmo/test/shishiginstepan/server/DistributedDao.java Outdated Show resolved Hide resolved

code climate

0295ac1

codeclimate bot reviewed Apr 16, 2024

View reviewed changes

code climate

3e296ca

codeclimate bot reviewed Apr 16, 2024

View reviewed changes

Степан added 2 commits April 17, 2024 02:20

code climate

2358ca2

maybe fix

89d05fe

codeclimate bot reviewed Apr 17, 2024

View reviewed changes

Степан added 2 commits April 17, 2024 20:10

maybe fix

eae83fc

one more fix (code was running in selectors)

7d7e844

codeclimate bot reviewed Apr 17, 2024

View reviewed changes

Степан added 2 commits April 17, 2024 22:04

code climate

b59212b

report

01b4134

incubos requested a review from vladimir-bf April 20, 2024 19:14

incubos assigned vladimir-bf Apr 20, 2024

incubos requested changes Apr 20, 2024

View reviewed changes

vladimir-bf assigned incubos and unassigned vladimir-bf Apr 24, 2024

incubos added 2 commits April 28, 2024 17:22

Merge branch 'main' into stage-5

1cb5b2d

Merge branch 'main' into stage-5

279872e

incubos requested review from incubos and removed request for vladimir-bf May 1, 2024 18:51

incubos requested changes May 1, 2024

View reviewed changes

Merge branch 'main' into stage-5

e71dde0

incubos approved these changes May 11, 2024

View reviewed changes

incubos merged commit 8046881 into polis-vk:main May 11, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HW 5 Шишигин Степан DWS ИТМО #197

HW 5 Шишигин Степан DWS ИТМО #197

sshishigin commented Apr 16, 2024

incubos left a comment

incubos left a comment

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos May 1, 2024

incubos left a comment

		Integer shouldAck = ack == null ? quorum : ack;
		Integer requestFrom = from == null ? totalNodes : from;

	MemorySegment.ofArray(request.getBody()), timestamp
	MemorySegment.ofArray(request.getBody()),
	timestamp

HW 5 Шишигин Степан DWS ИТМО #197

HW 5 Шишигин Степан DWS ИТМО #197

Conversation

sshishigin commented Apr 16, 2024

incubos left a comment

Choose a reason for hiding this comment

incubos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

incubos left a comment

Choose a reason for hiding this comment