-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Решетников Алексей, ИТМО DWS, stage 6 #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 17979 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 17981 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 17981 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 17981 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 19052 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
много алокаций а так же в отчете не сказано что мы все селектор треды можем забить отправив буквально несколько запросов, а так же не достает обработки ошибок
8 баллов
Что сделано
GET /v0/entities?start=<ID>[&end=<ID>]
добавлен билдерподумал, что если записывать все данные в один массив байтов, а затем отправлять их через сессию, то это не будет считаться потоковой передачей респонса. ПереписалChunkedResponseBuilder
, который билдит массив байтов для чанковой передачи респонсаChunkedResponseBuilder
(теперь он называетсяChunkedResponseSender
), теперь он генерит массив байтов определенного блока данных и сразу отправляет их через сессию