Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Решетников Алексей, ИТМО DWS, stage 6 #224

Closed
wants to merge 44 commits into from

Conversation

lehatheslayer
Copy link
Contributor

@lehatheslayer lehatheslayer commented Apr 25, 2024

Что сделано

  • добавлена новая ручка GET /v0/entities?start=<ID>[&end=<ID>]
  • добавлен билдер ChunkedResponseBuilder, который билдит массив байтов для чанковой передачи респонса подумал, что если записывать все данные в один массив байтов, а затем отправлять их через сессию, то это не будет считаться потоковой передачей респонса. Переписал ChunkedResponseBuilder (теперь он называется ChunkedResponseSender), теперь он генерит массив байтов определенного блока данных и сразу отправляет их через сессию

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17979 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17981 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17981 lines exceeds the maximum allowed for the inline comments feature.

@incubos incubos requested review from pashchenko8 and removed request for vladimir-bf April 29, 2024 15:59
@incubos incubos assigned pashchenko8 and unassigned vladimir-bf Apr 29, 2024
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17981 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 19052 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Contributor

@pashchenko8 pashchenko8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

много алокаций а так же в отчете не сказано что мы все селектор треды можем забить отправив буквально несколько запросов, а так же не достает обработки ошибок
8 баллов

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants