Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 6, Андрей Чешев, Политех #226

Merged
merged 135 commits into from
May 25, 2024

Conversation

Queenore
Copy link
Contributor

No description provided.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89763 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89763 lines exceeds the maximum allowed for the inline comments feature.

@incubos incubos requested a review from lamtev April 28, 2024 13:47
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89763 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89763 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89763 lines exceeds the maximum allowed for the inline comments feature.

Queenore added 2 commits May 4, 2024 13:50
…eshev

# Conflicts:
#	src/main/java/ru/vk/itmo/test/andreycheshev/ParametersParser.java
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89802 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89804 lines exceeds the maximum allowed for the inline comments feature.

Queenore added 4 commits May 4, 2024 19:26
…eshev

# Conflicts:
#	src/main/java/ru/vk/itmo/test/andreycheshev/RequestHandler.java
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89816 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89822 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 89822 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Member

@lamtev lamtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15 баллов

import java.util.Iterator;

public class StreamingSession extends HttpSession {
private static final int BUFF_SIZE = (2 << 10) * (2 << 10);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чем руководствовались при выборе размера буффера?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит странно. Как будто хотелось 2^10, но получилось 2^11


import java.io.IOException;

public class StreamingBuffer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сразу же пришла идея с буффером или в результате профилирования исходного решения без буффера?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Идея пришла сразу же. Возникла мысль, что вызов записи в сокет каждой entry по отдельности может быть неэффективным.

@incubos incubos merged commit 8664da6 into polis-vk:main May 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants