Tveritin Alexandr - DWS (Step-1) #30
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| function request() | ||
| local headers = {} | ||
| headers["Host"] = "localhost" | ||
| local id = math.random(1, 2000) |
There was a problem hiding this comment.
Всего 2К ключей? Насколько результатам тестирования можно будет доверять?
| request = function() | ||
| local headers = {} | ||
| headers["Host"] = "localhost" | ||
| local id = math.random(1, 2000) |
| local random_string = "" | ||
| local charset_length = string.len(charset) | ||
|
|
||
| math.randomseed(os.time()) |
There was a problem hiding this comment.
Зачем выставлять seed на каждый вызов?
| #[Buckets = 27, SubBuckets = 2048] | ||
| ---------------------------------------------------------- | ||
| 299980 requests in 30.00s, 19.74MB read | ||
| Non-2xx or 3xx responses: 160 |
There was a problem hiding this comment.
Чем объяснить эти необычные ответы?
| ---------------------------------------------------------- | ||
| 299980 requests in 30.00s, 19.74MB read | ||
| Non-2xx or 3xx responses: 160 | ||
| Requests/sec: 9999.35 |
There was a problem hiding this comment.
Почему в отчёте 20К rps?
./wrk -d 30 -t 1 -c 1 -R 20000 -L -s
| private static final Response RESPONSE_NOT_FOUND = new Response(Response.NOT_FOUND, Response.EMPTY); | ||
| private static final Response RESPONSE_BAD_REQUEST = new Response(Response.BAD_REQUEST, Response.EMPTY); | ||
| private static final Response RESPONSE_CREATED = new Response(Response.CREATED, Response.EMPTY); | ||
| private static final Response RESPONSE_ACCEPTED = new Response(Response.ACCEPTED, Response.EMPTY); | ||
| private static final Response RESPONSE_NOT_ALLOWED = new Response(Response.METHOD_NOT_ALLOWED, Response.EMPTY); |
There was a problem hiding this comment.
Причина проблем с большой нагрузкой может быть в этих закешированных объектах Response -- обсуждали на втором занятии.
| if (id.isEmpty()) return RESPONSE_BAD_REQUEST; | ||
| MemorySegment key = MemorySegment.ofArray(id.getBytes(StandardCharsets.UTF_8)); | ||
|
|
||
| Entry<MemorySegment> resultEntry = dao.get(key); |
There was a problem hiding this comment.
Здесь и ниже не обрабатываются возможные исключения DAO.
| private static final Response RESPONSE_ACCEPTED = new Response(Response.ACCEPTED, Response.EMPTY); | ||
| private static final Response RESPONSE_NOT_ALLOWED = new Response(Response.METHOD_NOT_ALLOWED, Response.EMPTY); | ||
|
|
||
| private final DaoImpl dao; |
There was a problem hiding this comment.
Почему конкретный класс, а не интерфейс Dao?
| public Response upsert(@Param(value = "id", required = true) String id, Request request) { | ||
| if (id.isEmpty()) return RESPONSE_BAD_REQUEST; | ||
| MemorySegment key = MemorySegment.ofArray(id.getBytes(StandardCharsets.UTF_8)); | ||
| MemorySegment value = MemorySegment.ofArray(request.getBody()); |
There was a problem hiding this comment.
Если тела не будет, то PUTом выполним DELETE? Выглядит не совсем корректно.
| public synchronized void stop() { | ||
| super.stop(); | ||
| try { | ||
| dao.close(); |
There was a problem hiding this comment.
Освобождать ресурсы желательно там же, где их выделили, т.е. в ServiceImpl -- иначе сложно рассуждать об их жизненном цикле.
No description provided.