Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] Tutorials -> Build a Parachain -> Prepare a local relay chain #16

Merged
merged 23 commits into from
Sep 24, 2024

Conversation

nhussein11
Copy link
Collaborator

The "Prepare a local relay chain" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-parachain/prepare-a-local-relay-chain/

@nhussein11 nhussein11 requested a review from 0xLucca September 9, 2024 19:36
@nhussein11 nhussein11 force-pushed the nhussein11/tutorials-substrate-prepare-relay-chain branch from 70bd312 to 213814e Compare September 11, 2024 16:53
@nhussein11 nhussein11 force-pushed the nhussein11/tutorials-substrate-prepare-relay-chain branch from 7fb4027 to f8b1fa8 Compare September 11, 2024 16:56
@nhussein11 nhussein11 requested a review from 0xLucca September 11, 2024 17:04
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 23, 2024
dawnkelly09
dawnkelly09 previously approved these changes Sep 23, 2024
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Nico! Please fix merge conflicts :-)

@nhussein11
Copy link
Collaborator Author

@eshaben @dawnkelly09 already applied feedback here. Could you please approve this PR again so I can merge it? 🙏

Thank you!

Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhussein11 nhussein11 merged commit 697df52 into master Sep 24, 2024
1 check failed
@nhussein11 nhussein11 deleted the nhussein11/tutorials-substrate-prepare-relay-chain branch September 24, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants