Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page Develop -> Testing -> Benchmarking #305

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update page Develop -> Testing -> Benchmarking #305

wants to merge 5 commits into from

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Jan 15, 2025

Add some improvements and missing explanations

@0xLucca 0xLucca requested a review from a team as a code owner January 15, 2025 19:40
@0xLucca 0xLucca added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Jan 15, 2025
CrackTheCode016
CrackTheCode016 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

develop/parachains/testing/benchmarking.md Show resolved Hide resolved
@eshaben eshaben requested a review from dawnkelly09 January 17, 2025 07:55
nhussein11
nhussein11 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor details. LGTM!

develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
dawnkelly09
dawnkelly09 requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out suggested changes, look at the feedback from others, make sure updates are made (or convos resolved) for all then request new review for approval. Thanks!

develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
develop/parachains/testing/benchmarking.md Outdated Show resolved Hide resolved
0xLucca and others added 2 commits January 21, 2025 16:47
@0xLucca @nhussein11 @dawnkelly09
Apply suggestions from code review
4618efb 
Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
@0xLucca
Apply fixes
92c3c08
@0xLucca 0xLucca requested a review from dawnkelly09 January 21, 2025 19:52
0xlukem
0xlukem reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@0xlukem 0xlukem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny fix in the description, LGTM 💯

dawnkelly09
dawnkelly09 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@0xLucca 0xLucca requested a review from 0xlukem January 22, 2025 16:13
@0xLucca 0xLucca requested a review from nhussein11 January 22, 2025 16:19
@0xLucca 0xLucca added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 22, 2025
@eshaben
Copy link
Collaborator

eshaben commented Jan 24, 2025

@0xLucca, I just noticed there are some merge conflicts here to resolve

@kapetan3sid kapetan3sid linked an issue Jan 24, 2025 that may be closed by this pull request
Update Benchmarking guide in Develop section #323
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xlukem 0xlukem 0xlukem approved these changes

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@nhussein11 nhussein11 nhussein11 approved these changes

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to be Merged Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Benchmarking guide in Develop section
6 participants
@0xLucca @eshaben @CrackTheCode016 @nhussein11 @dawnkelly09 @0xlukem