Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Staking with latest breaking changes! #10498

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Apr 24, 2024

closes: #10396
closes: #10482

With the most recent breaking changes in the api polkadot-js/api#5860 polkadot-js/api#5862 due to changes in pallet-staking, this PR hopes to fix a lot of those issues.

Just to preface, it is very possible that this PR does not fix every issue that might be present but it is a step in the right direction. What I mean by this is there is a lot changes and logic that were covered in the above PR's and it is difficult to track every single one down in the UI, and how that data might be nested to x amount of Components.

I also updated all the following deps:

@polkadot/api -> 11.0.1
@polkadot/extension -> 0.47.2
@polkadot/phishing -> 0.22.6
@polkadot/tools -> 0.56.8

Disclaimer!! This does not touch the page-staking2 components (As noted by Jaco it seems to have been a staking test app). When the time comes if needed I can update that as well.

@TarikGul
Copy link
Member Author

TarikGul commented Apr 24, 2024

Currently getting the error:

useCall.ts:43 Error: useCall(...):: -32006: Too many subscriptions on the connection: Exceeded max limit of 1024:: RpcError: -32006: Too many subscriptions on the connection: Exceeded max limit of 1024

I would assume it's from the following: https://github.com/polkadot-js/api/blob/master/packages/api-derive/src/staking/query.ts#L103-L126

@TarikGul
Copy link
Member Author

By removing withClaimedRewardsEras it ended up working as is. Not sure how it effects claimedRewards yet though. I am also willing to just merge this in and fix that regression seperately.

@TarikGul TarikGul added the -auto label Apr 24, 2024
@polkadot-js-bot polkadot-js-bot merged commit 7a897ea into master Apr 24, 2024
7 checks passed
@polkadot-js-bot polkadot-js-bot deleted the tg-fix-staking-pjs branch April 24, 2024 18:48
@TarikGul TarikGul mentioned this pull request Apr 24, 2024
4 tasks
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent metadata update introduced several UI problems on Kusama Staking upcoming todos
2 participants