feat: enhancing report results processing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, removing row index column from result
y3pio
commented
Feb 19, 2021
| df.to_csv(outfile, index=False) |
y3pio
commented
Feb 19, 2021
| "issueURL_HTML": r['html_url'], | ||
| "commentLine": processComment(line), | ||
| "commentURL": r['html_url'] # Same as issue html url | ||
| }) |
There was a problem hiding this comment.
However note that GitHub does not readily provides the html_url for the issue body comment (description). Using the same html_url as the issue for now for the commentURL for the issue description, as going to that link will bring us directly to the issue and the top comment will be the comment that we are looking at anyway.
y3pio
commented
Feb 19, 2021
| @@ -178,11 +196,11 @@ | |||
| CORPUS.append({ | |||
| "issueID": url['issueID'], | |||
| "issueURL_API": comment['issue_url'], | |||
| "issueURL_HTML": url['issueURL_HTML'], | |||
This was
linked to
issues
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the below issues:
#16 - Added issue comment body as part of comments to be processed
#17 - Remove row index number column from output CSV
#18 - Adding HTML url of issue.
Sample output below of updated result processing:
issueURL_HTMLcommentURis just theissueURL_HTMLitself as I don't see a way that GitHub readily gives you the specific issue's body comment (description) URL like the one you linked in issue Description not considered a comment? #16