Swap Vanity URLs [DRAFT] #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toph-allen
force-pushed
the
toph/swap-vanity-urls
branch
from
cc84f6f to
fc5e5bd
Compare
|
It's currently hard-coded to show a single user's content. When Connect can use viewer API keys, it should be updated to use that. However, for admins, who can edit vanity URLs for all users, we could default to showing all content items. To do this, however, I'll need to add pagination to the list view (while storing the selected items), so that'll probably need some refactoring. In that case, might also want to add a toggle between "all items" and "your items". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This app is a draft.