Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postgresql known issues #312

Merged
merged 5 commits into from
May 14, 2024
Merged

Fix postgresql known issues #312

merged 5 commits into from
May 14, 2024

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented May 14, 2024

Fixes known issues on PostgreSQL. These fixes have been validated on #307. The build including PostgreSQL is bein prepared on that PR, but have been cherry-picked here to unblock users of Audiences.

  • Use unique_by when needed
  • Aggregate failures
  • Assert on ordered data
  • Allow user search on multiple adapters

@xjunior xjunior requested a review from a team as a code owner May 14, 2024 13:24
phylum
phylum previously approved these changes May 14, 2024
View reviewed changes
ryan-on-rails
ryan-on-rails previously approved these changes May 14, 2024
View reviewed changes
Copy link

@ryan-on-rails ryan-on-rails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@xjunior xjunior dismissed stale reviews from ryan-on-rails and phylum via 7394796 May 14, 2024 13:36
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=fix-postgresql-issues

@xjunior xjunior added the enhancement New feature or request label May 14, 2024
web-kat
web-kat approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@web-kat web-kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are we officially supporting PostreSQL in this project? Are there any other DB considerations we need to make? Not a blocker, mainly just curious

@xjunior xjunior merged commit 2d3cb6b into main May 14, 2024
16 checks passed
@xjunior xjunior deleted the fix-postgresql-issues branch May 14, 2024 14:08
@xjunior
Copy link
Contributor Author

xjunior commented May 14, 2024

LGTM. Are we officially supporting PostreSQL in this project? Are there any other DB considerations we need to make? Not a blocker, mainly just curious

Yes. Runway and Connect v3 both use PostgreSQL. I have a PR open to help catch any possible issues with PostgreSQL. The CI there is currently passing with the fixes above; however, there have been some challenges with other parts of the CI – license finder, release process… I hope to get this new build workflow out by the end of the week, but wanted to unblock this work for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-kat web-kat web-kat approved these changes

@stephenagreer stephenagreer stephenagreer approved these changes

@phylum phylum phylum approved these changes

@ryan-on-rails ryan-on-rails ryan-on-rails left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xjunior @ryan-on-rails @phylum @stephenagreer @web-kat