Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade packages & refactor scroll position hook #435

Merged
merged 2 commits into from
Nov 7, 2023
Merged

upgrade packages & refactor scroll position hook #435

merged 2 commits into from
Nov 7, 2023

Conversation

prabhuignoto
Copy link
Owner

@prabhuignoto prabhuignoto commented Nov 7, 2023 •
edited
Loading

Description

  • refactoring useNewScrollPosition
  • updated packages

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@prabhuignoto
upgrade packages
1ebd9e4 
refactored useNewScrollPosition
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chrono-uc7v ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:27am

@restyled-io restyled-io bot mentioned this pull request Nov 7, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/react-chrono.js 28.98 KB (+0.01% 🔺) 580 ms (+0.01% 🔺) 178 ms (-60.54% 🔽) 758 ms
dist/react-chrono.esm.js 29.05 KB (0%) 582 ms (0%) 103 ms (-61.85% 🔽) 684 ms
dist/react-chrono.umd.js 32.65 KB (+0.01% 🔺) 654 ms (+0.01% 🔺) 182 ms (-48.31% 🔽) 835 ms

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prabhuignoto prabhuignoto changed the title upgrade packages upgrade packages & refactor scroll position hook Nov 7, 2023
@prabhuignoto prabhuignoto merged commit 7a59cd3 into master Nov 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prabhuignoto