fix: reactivity in .subscribe() method

prevwong · May 14, 2023 · 5609f03 · 5609f03 · vercel · May 14, 2023
1 parent 3aac6a3
commit 5609f03
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/silly-pots-drum.md b/.changeset/silly-pots-drum.md
@@ -0,0 +1,5 @@
+---
+'@rekajs/core': patch
+---
+
+Persist reactivity in .subscribe method
diff --git a/packages/core/src/reka.ts b/packages/core/src/reka.ts
@@ -15,7 +15,6 @@ import { Frame, FrameOpts } from './frame';
 import { Head } from './head';
 import { StateOpts, StateSubscriberOpts } from './interfaces';
 import { ChangeListenerSubscriber, Observer } from './observer';
-import { toJS } from './utils';
 
 export class Reka {
   id: string;
@@ -231,11 +230,11 @@ export class Reka {
    */
   subscribe<C>(
     collect: (reka: Reka) => C,
-    onCollect: (collected: C, prevCollected: C) => void,
+    onCollect: (collected: C, prevCollected: C | undefined) => void,
     opts?: StateSubscriberOpts
   ) {
     const dispose = reaction(
-      () => toJS(collect(this)),
+      () => collect(this),
       (collected, prevCollected) => onCollect(collected, prevCollected),
       {
         fireImmediately: opts?.fireImmediately,