Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading usage on pButton directive with new directives loses icon #17296

Open
4 tasks
egorbwork opened this issue Jan 5, 2025 · 0 comments · May be fixed by #17295
Open
4 tasks

Loading usage on pButton directive with new directives loses icon #17296

egorbwork opened this issue Jan 5, 2025 · 0 comments · May be fixed by #17295
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
19.1.0

Comments

@egorbwork
Copy link

Describe the bug

When we use loading binding on pButton directive with the new directives, we lose the icon after loading becomes again false.

Pull Request Link

#17295

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-ytb4rw4l?file=src%2Fapp%2Fapp.component.ts

Environment

Ubuntu 22

Angular version

19

PrimeNG version

v19

Node version

18

Browser(s)

No response

Steps to reproduce the behavior

  1. Add a button with pButton directive with new directives for label and icon.
  2. Configure loading binding for that button
  3. Use loading true
  4. Use loading false
    Result: The icon is lost

Expected behavior

The icon will be restored.
@egorbwork egorbwork added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 5, 2025
@egorbwork egorbwork linked a pull request Jan 5, 2025 that will close this issue
Open
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 15, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Review
Milestone
19.1.0
2 participants
@mertsincan @egorbwork